Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix issues and add test cases for payment #348

Merged
merged 36 commits into from
Jul 21, 2023
Merged

feat: fix issues and add test cases for payment #348

merged 36 commits into from
Jul 21, 2023

Conversation

forcodedancing
Copy link
Contributor

@forcodedancing forcodedancing commented Jul 17, 2023 •
edited
Loading

Description

This pr will fix several issues in payment and related modules, it also add more test cases for payment.

Rationale

Bug fix and test enhancement

Example

NA

Changes

Notable changes:

  • the lockfee will include the fee to validator tax pool

@forcodedancing forcodedancing marked this pull request as draft July 17, 2023 01:51
@fynnss fynnss added the r4r label Jul 20, 2023
forcodedancing
forcodedancing commented Jul 20, 2023
View reviewed changes
e2e/core/basesuite.go Outdated Show resolved Hide resolved
@forcodedancing forcodedancing marked this pull request as ready for review July 21, 2023 02:27
@yutianwu
Copy link
Collaborator

there are lint errors, pls also check

fynnss
fynnss approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randyahx randyahx mentioned this pull request Jul 21, 2023
Merged
@forcodedancing forcodedancing added this pull request to the merge queue Jul 21, 2023
Merged via the queue into bnb-chain:develop with commit e7d0662 Jul 21, 2023
5 checks passed
@randyahx randyahx mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro left review comments

@yutianwu yutianwu yutianwu approved these changes

@fynnss fynnss fynnss approved these changes

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@forcodedancing @yutianwu @unclezoro @fynnss @MockY-B